Modify

Opened 6 years ago

Closed 5 years ago

#9556 closed defect (fixed)

[Patch] Resource name not displayed after clicking the bookmark icon

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: BookmarkPlugin
Severity: normal Keywords: pull-request
Cc: Jun Omae Trac Release: 0.11

Description (last modified by Ryan J Ollos)

After clicking on the add / remove bookmark icon and then hovering over the drop-down bookmark list, the following is shown:

After a page refresh, the following is shown:

Attachments (3)

AfterRefresh.png (4.9 KB) - added by Ryan J Ollos 6 years ago.
AfterSelectingBookmarkIcon.png (5.2 KB) - added by Ryan J Ollos 6 years ago.
th9556_Trac012_BookmarkPlugin_r10436.diff (2.2 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (15)

Changed 6 years ago by Ryan J Ollos

Attachment: AfterRefresh.png added

Changed 6 years ago by Ryan J Ollos

comment:1 Changed 6 years ago by Ryan J Ollos

Cc: Jun Omae added; anonymous removed

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)
Summary: Resource name not dislayed after clicking the bookmark icon[Patch] Resource name not dislayed after clicking the bookmark icon

comment:3 Changed 5 years ago by Ryan J Ollos

Keywords: pull-request added

The functionality was all there, just some internal reorganization was necessary. The attached patch resolves the issue. I'll gladly revise based on feedback about style issues, or any other suggestions.

There is no activity on this plugin for almost a year, so I'm inquiring about maintainership status and requesting permission to push this patch to the repository. I'll proceed if I don't hear back for two weeks, in accordance with AdoptingHacks (though I don't wish to officially maintain this, just to push some patches).

Changed 5 years ago by Ryan J Ollos

comment:4 Changed 5 years ago by Ryan J Ollos

Summary: [Patch] Resource name not dislayed after clicking the bookmark icon[Patch] Resource name not displayed after clicking the bookmark icon

comment:6 Changed 5 years ago by yosiyuki

rolls, sorry for leaving your request to BookmarkPlugin. I just requested this site owner to join you as a commiter of Bookmark Plugin.

I'm trying to my env to develop trac plugins in a couple of weeks, anyway.

comment:7 Changed 5 years ago by Ryan J Ollos

Thank you! I'm one of the admins, so I can give myself commit access. I just needed your permission to push changes to your project.

Did you have any thoughts on the quality of the patch?: https://bitbucket.org/rjollos/bookmarkplugin/changeset/8edba9d52edf.

comment:8 Changed 5 years ago by anonymous

I'm definitely grad you to push your commit to BookmarkPlugin. Please go ahead. I don't have any problem with your patch.

comment:9 Changed 5 years ago by Ryan J Ollos

Thanks. I'll leave it on BitBucket for another week or two since I'm planning to work on a few other defects / enhancements for the plugin, and then pull in all the changes and bump the plugin rev. I'll try to coordinate with you and jun66j5.

comment:10 Changed 5 years ago by Ryan J Ollos

Also, I saw that unit tests were added in [11273], so I'll change the scope of the method that I added and try to add some unit tests.

comment:11 Changed 5 years ago by Ryan J Ollos

I'll pull this change in for version 0.2 of the plugin.

comment:12 Changed 5 years ago by Ryan J Ollos

Owner: changed from yosiyuki to Ryan J Ollos
Status: newassigned

comment:12 Changed 5 years ago by Jun Omae

Resolution: fixed
Status: assignedclosed

(In [11893]) bookmarkplugin:

  • fixed #9556: Shows the resource name after clicking the bookmark icon
  • fixed #9557: "Bookmarks" link in #ctxtnav has fluid width and fits the width of bookmarks dropdown
  • fixed #9749: Shows "Bookmarks" link instead of the first list of #bookmark_menu

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.