Opened 13 years ago
Closed 12 years ago
#9556 closed defect (fixed)
[Patch] Resource name not displayed after clicking the bookmark icon
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Component: | BookmarkPlugin |
| Severity: | normal | Keywords: | pull-request |
| Cc: | Jun Omae | Trac Release: | 0.11 |
Description (last modified by )
After clicking on the add / remove bookmark icon and then hovering over the drop-down bookmark list, the following is shown:
After a page refresh, the following is shown:
Attachments (3)
Change History (15)
Changed 13 years ago by
| Attachment: | AfterRefresh.png added |
|---|
Changed 13 years ago by
| Attachment: | AfterSelectingBookmarkIcon.png added |
|---|
comment:1 Changed 13 years ago by
| Cc: | Jun Omae added; anonymous removed |
|---|
comment:2 Changed 13 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Resource name not dislayed after clicking the bookmark icon → [Patch] Resource name not dislayed after clicking the bookmark icon |
comment:3 Changed 13 years ago by
| Keywords: | pull-request added |
|---|
Changed 13 years ago by
| Attachment: | th9556_Trac012_BookmarkPlugin_r10436.diff added |
|---|
comment:4 Changed 13 years ago by
| Summary: | [Patch] Resource name not dislayed after clicking the bookmark icon → [Patch] Resource name not displayed after clicking the bookmark icon |
|---|
comment:6 Changed 13 years ago by
rolls, sorry for leaving your request to BookmarkPlugin. I just requested this site owner to join you as a commiter of Bookmark Plugin.
I'm trying to my env to develop trac plugins in a couple of weeks, anyway.
comment:7 Changed 13 years ago by
Thank you! I'm one of the admins, so I can give myself commit access. I just needed your permission to push changes to your project.
Did you have any thoughts on the quality of the patch?: https://bitbucket.org/rjollos/bookmarkplugin/changeset/8edba9d52edf.
comment:8 Changed 13 years ago by
I'm definitely grad you to push your commit to BookmarkPlugin. Please go ahead. I don't have any problem with your patch.
comment:9 Changed 13 years ago by
Thanks. I'll leave it on BitBucket for another week or two since I'm planning to work on a few other defects / enhancements for the plugin, and then pull in all the changes and bump the plugin rev. I'll try to coordinate with you and jun66j5.
comment:10 Changed 13 years ago by
Also, I saw that unit tests were added in [11273], so I'll change the scope of the method that I added and try to add some unit tests.
comment:12 Changed 13 years ago by
| Owner: | changed from yosiyuki to Ryan J Ollos |
|---|---|
| Status: | new → assigned |
comment:12 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The functionality was all there, just some internal reorganization was necessary. The attached patch resolves the issue. I'll gladly revise based on feedback about style issues, or any other suggestions.
There is no activity on this plugin for almost a year, so I'm inquiring about maintainership status and requesting permission to push this patch to the repository. I'll proceed if I don't hear back for two weeks, in accordance with AdoptingHacks (though I don't wish to officially maintain this, just to push some patches).