Modify

Opened 2 years ago

Closed 22 months ago

#10397 closed defect (fixed)

Don't allow username with all capital letters

Reported by: adeel.asghar@… Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: user registration check
Cc: rjollos Trac Release: 0.12

Description

I have installed TracAccountManager 0.4dev-r12000. This allows users to register with a username that can have all capital letters. Is there a way to stop this? Later I want to set permissions on the users but i can't set them if the username is all capital letters.

Attachments (0)

Change History (9)

comment:1 Changed 2 years ago by hasienda

  • Cc rjollos added
  • Keywords configuration support added
  • Priority changed from highest to normal
  • Resolution set to worksforme
  • Severity changed from blocker to normal
  • Status changed from new to closed

You're welcome to test trunk as it's currently release candidate for acct_mgr-0-4. Thank you for taking care.

Still, there is a another, preferred way to ask for support than suggesting a bug in the corresponding plugin, and you've already been told to not use a ticket for these kind of questions at our new ticket page. This is about playing nice in a FOSS environment, where this ticket system here is dedicated to plugin development issues and real bugs.

Better ask this kind of question to our t:wiki:MailingList, please.

I went there to replicate your question and give an appropriate answer as well:

https://groups.google.com/d/topic/trac-users/0MQW7fO77RY/discussion

Last note: prio=highest and severity=blocker? Don't treat me like that for contributing my knowledge and time here - for free. Understand, that attracting attention this way is considered bad habit or worse. You do use development code and seem to not have spend much time with neither commit log history nor wiki documentation for this plugin, if any. Don't dare to do that again, please!

comment:2 Changed 2 years ago by hasienda

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Well, nobody is perfect. A fellow developer finally convinced me, that you've hit a weak spot indeed. So let's deal with it like programmers.

comment:3 Changed 2 years ago by hasienda

  • Keywords user registration check added; configuration support removed

comment:4 follow-up: Changed 2 years ago by rjollos

Of course, your original point remains very valid and should not be lost on the reporter - that the issues are best discussed over the mailing list prior to opening a defect. Now, with the mailing list there is greater exposure to the change and the greater possibility of follow-up comments and opinions. Thank you for your efforts to fix the issue!

comment:5 Changed 2 years ago by hasienda

(In [12083]) AccountManagerPlugin: Prevent all upper-cased usernames, refs #10397.

Thanks to Adeel Asgha for the initial suggestion despite of my first reaction.

Thinking a bit, and after a friendly nudge by Ryan this seems like a pretty
basic requirement indeed, that should even have come-up much earlier.
Easy enough to enforce it in BasicCheck for new user registrations now.

comment:6 in reply to: ↑ 4 ; follow-up: Changed 2 years ago by hasienda

Replying to rjollos:

Of course, your original point remains very valid and should not be lost on the reporter - that the issues are best discussed over the mailing list prior to opening a defect. Now, with the mailing list there is greater exposure to the change and the greater possibility of follow-up comments and opinions.

Thought to react more often like so in the future, for saving us a bit of tedious Q&A sessions in our ticket system. Even more as ticket comments perform sub-optimal for extended arguments, or worse.

Thank you for your efforts to fix the issue!

You're welcome. Not always is it possible to just go for it. Luckily I could today, and glad to have it in for the next release. All the recent work on the registration makes me feel confident, that acct_mgr-0.4 will be indeed a major milestone and big improvement compared to current stable. Once again thanks for your feedback.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 2 years ago by anonymous

Replying to hasienda:

Replying to rjollos:

Of course, your original point remains very valid and should not be lost on the reporter - that the issues are best discussed over the mailing list prior to opening a defect. Now, with the mailing list there is greater exposure to the change and the greater possibility of follow-up comments and opinions.

Thought to react more often like so in the future, for saving us a bit of tedious Q&A sessions in our ticket system. Even more as ticket comments perform sub-optimal for extended arguments, or worse.

Thank you for your efforts to fix the issue!

You're welcome. Not always is it possible to just go for it. Luckily I could today, and glad to have it in for the next release. All the recent work on the registration makes me feel confident, that acct_mgr-0.4 will be indeed a major milestone and big improvement compared to current stable. Once again thanks for your feedback.

Thanks hasienda for fixing it. I tried to find a mailing list but couldn't find it here. Perhaps I haven't searched properly. Thanks again!!!

comment:8 in reply to: ↑ 7 Changed 2 years ago by hasienda

Replying to anonymous:

Replying to hasienda:

...

Thanks hasienda for fixing it. I tried to find a mailing list

Really? Well, it would be a big overhead to put it into every single plugin page.

but couldn't find it here. Perhaps I haven't searched properly. Thanks again!!!

You'll find a hint on the bottom of our front page in section Feedback and Suggestions, of course. It's directing to t:wiki:MailingList. Consider a subscription to trac-users, that will enable you to ask your support questions as advised above, and track plugin issues, that others point out as well. Thanks for consideration.

Technical note: This ticket is left open intentionally and will be closed, when tractags-0.7 get released.

comment:9 Changed 22 months ago by hasienda

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [12398]) AccountManagerPlugin: Releasing version 0.4, pushing development to acct_mgr-0.5dev.

Availability of that code as stable release
closes #874, #3459, #4677, #5295, #5691, #6616, #7577, #8076, #8685, #8770, #8791, #8990, #9052, #9079, #9090, #9139, #9246, #9252, #9547, #9618, #9676, #9843, #9852, #9940, #10023, #10028, #10123, #10142, #10204, #10276, #10397, #10412, #10594, #10625 and #10644.

Some more issues have been worked-on, yet without confirmed resolution,
refs #5464 (for JiraToTracIntegration), #8927 and #10134.

And finally there are some issues and enhancement requests showing progress,
but known to require more work to resolve them satisfactorily,
refs #843, #1600, #5964, #8217, #8933.

Thanks to all contributors and followers, that enabled and encouraged a good
portion of this development work.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.