Modify

Opened 5 years ago

Closed 5 years ago

#12434 closed defect (fixed)

AttributeError: 'NoneType' object has no attribute 'get'

Reported by: Ryan J Ollos Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Found the following in the logs. As in#12105, we probably just need to check for the case that post_process_request is called with the Request object as the only argument after an exception occurs processing the request.

2015-07-06 12:00:33,364 Trac[main] ERROR: Exception caught while post-processing request:
Traceback (most recent call last):
  File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.6post2-py2.6.egg/trac/web/main.py", line 257, in dispatch
    self._post_process_request(req)
  File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/Trac-1.0.6post2-py2.6.egg/trac/web/main.py", line 370, in _post_process_request
    f.post_process_request(req, *(None,)*extra_arg_count)
  File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/TracTags-0.8dev-py2.6.egg/tractags/web_ui.py", line 428, in post_process_request
    if data.get('events') and query_str:
AttributeError: 'NoneType' object has no attribute 'get'

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by Steffen Hoffmann

In 14786:

TagsPlugin: Skip timeline event filter in case of error response, refs #12434.

Improve backwards-compatibility by replacing req.session.set(), that has been
unavailable before Trac 0.12.4 - a discovery from one of the added unit tests.
The unit test request mockup was inspired by Ryan J. Ollos recent test code for
VotePlugin.

comment:2 Changed 5 years ago by Ryan J Ollos

Thanks for the fix! Deployed to the new trac-hacks server for testing.

comment:3 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 14945:

0.8: Tag 0.8 release

Fixes #1304, #1344, #3660, #3891, #9064, #9797, #11661, #11690, #11695, #11888, #11950, #11954, #11968, #12202, #12292, #12434, #12486.

Refs #12415.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.