Opened 10 years ago
Closed 9 years ago
#11968 closed enhancement (fixed)
Add method TagSystem.get_taggable_realms
Reported by: | Ryan J Ollos | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | TagsPlugin |
Severity: | normal | Keywords: | refactoring |
Cc: | Trac Release: |
Description
While reviewing some of the code, I noticed the possibility for some refactoring by adding a method to the TagSystem
. I'll attach the proposed changes as a patch file.
Attachments (1)
Change History (9)
Changed 10 years ago by
Attachment: | t11968.patch added |
---|
comment:1 Changed 10 years ago by
comment:5 follow-up: 7 Changed 10 years ago by
Replying to hasienda:
One small but significant alteration was using built-in list()
for the XMLRPC method. [set(..)]
would have returned a list with the set as element.
comment:6 Changed 10 years ago by
Thanks for the inspiration. IMHO this has yielded considerable improvements.
comment:7 Changed 10 years ago by
Replying to hasienda:
One small but significant alteration was using built-in
list()
for the XMLRPC method.[set(..)]
would have returned a list with the set as element.
Good catch. I hadn't stopped to consider the difference in behavior before, between list()
and []
.
Yes, I know all these, even if I've been unaware of the three-fold extension point definition.
The new
TagSystem
API method is straight-forward too. Will push this this weekend with a few more changes. Thanks for taking care.