Modify

Opened 10 years ago

Closed 18 months ago

#1344 closed enhancement (fixed)

Choose tags via dropdown list

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: minor Keywords:
Cc: Ryan J Ollos Trac Release: 0.11

Description

Add <select> field filled with all tags.

Attachments (0)

Change History (14)

comment:1 Changed 10 years ago by anonymous

With a select field, how could you select multiple tags?

I think an AJAX solution would be better. The recognised tags could be auto-completed as you type.

comment:2 Changed 10 years ago by rupert thurner

see ajax bandbox, t:#5378

comment:3 Changed 9 years ago by Alec Thomas

This would definitely need some JavaScript to make it usable. A drop-down with all available tags would be extremely long.

comment:4 Changed 8 years ago by anonymous

you might be able to work with with the KeywordSuggestPlugin that already has this functionality, but is missing some functionality available in TagsPlugin, see ticket #3816

comment:5 Changed 8 years ago by Ryan J Ollos

This is implemented in #4201 for the KeywordSuggestPlugin.

comment:6 Changed 4 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added; anonymous removed

It's great, invaluable addition to TagsPlugin, and a must-have as soon as users get accustomed to it.

So how about integration? TagsPlugin would benefit from this, and an initial, canonical set of tags might be a good thing to have for new projects too. Licenses match as well AFAIKS. Like with the date-picker addition coming in Trac 1.1dev lately, have more feature-complete plugins might be good. In fact we've discussed this a lot in the past.

What do you see against a merger? You invested quite some time to modernize the code recently, so I would certainly respect any point brought up from your side. Why KeywordSuggestPlugin should better stay on it's own, thoughts?

comment:7 in reply to:  6 ; Changed 4 years ago by Ryan J Ollos

Replying to hasienda:

So how about integration?

Yes, I am all for it. In fact, you reminded me tonight, of outstanding issues with KeywordSuggestPlugin that I have let go on for far too long, so I have made an effort to fix those this evening.

TagsPlugin would benefit from this, and an initial, canonical set of tags might be a good thing to have for new projects too. Licenses match as well AFAIKS.

KeywordSuggestPlugin's license was clarified as 3-Clause BSD in #10037, so I also think that licenses should match.

Like with the date-picker addition coming in Trac 1.1dev lately, have more feature-complete plugins might be good. In fact we've discussed this a lot in the past.

Yes, definitely. Couple the UI functionality with the underlying plugin, and gets TagsPlugin even closer to being ready for eventual integration into the Trac core ;)

What do you see against a merger? You invested quite some time to modernize the code recently, so I would certainly respect any point brought up from your side. Why KeywordSuggestPlugin should better stay on it's own, thoughts?

No objections from me. I'd like to fix a few bugs, and then perhaps we should do a code review of KeywordSuggestPlugin. At that point, it could be moved over. In the meantime, don't hesitate to make changes directly to the KeywordSuggestPlugin codebase, whenever you see fit.

We might want to post to the trac-users mailing list the following question: Is anyone using KeywordSuggestPlugin without TagsPlugin? I suspect very few, and those few could still install the TagsPlugin egg and just enable the component that provides the keyword suggestion functionality.

Would you target this to Tags-0.7 or Tags-0.8?

comment:8 in reply to:  7 Changed 4 years ago by Steffen Hoffmann

Replying to rjollos:

Replying to hasienda:

So how about integration?

Yes, I am all for it. In fact, you reminded me tonight, of outstanding issues with KeywordSuggestPlugin that I have let go on for far too long, so I have made an effort to fix those this evening.

Thanks, great.

...

Would you target this to Tags-0.7 or Tags-0.8?

Definitely tags-0.8. This will be a major change, and current release stage is almost set by now.

comment:9 Changed 3 years ago by Steffen Hoffmann

In 13860:

TagsPlugin: Merge code from KeywordSuggestPlugin's current trunk (0.5.0dev), refs #1344, #3816, #4201 and #4503.

Functional overlap of the aforementioned plugin with TagsPlugin is a fact.
TagsPlugin lacking auto-complete-style assistance for 'keyword' alias tag
input fields took a lot from its potential efficiency.

Consequently KeywordSuggestPlugin is getting integrated from now.
Maintaining said plugin separately as another low-profile plugin for users
that dislike TagsPlugin might still happen depending on developer priorities
and user feedback.

PEP8 clean-up and move to TagsPlugin >= 0.7 performance-enhanced API for
querying current tag list has been done on the way.

comment:10 Changed 3 years ago by Steffen Hoffmann

In 13861:

TagsPlugin: Correct unit tests for TagInputAutoComplete after copy-n-paste, refs #1344.

With xmlrpclib and TracXMLRPC (http://trac-hacks.org/wiki/XmlRpcPlugin)
available all 72 tests pass now.

comment:11 Changed 3 years ago by Steffen Hoffmann

In 13867:

TagsPlugin: Refit of configuration options inherited from KeywordSuggestPlugin, refs #1344, #3816, #4201 and #11690.

Included are minor changes for component doc-strings as follow-up to [13865].

comment:12 Changed 3 years ago by Steffen Hoffmann

Owner: changed from Alec Thomas to Steffen Hoffmann
Status: newassigned

A migration guide is on the way.

Testers welcome to proof functionality for next (tractags-0.8) release.

comment:13 Changed 3 years ago by Steffen Hoffmann

In 13874:

TagsPlugin: Adapt unit tests to [13867], refs #1344.

comment:14 Changed 18 months ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

In 14945:

0.8: Tag 0.8 release

Fixes #1304, #1344, #3660, #3891, #9064, #9797, #11661, #11690, #11695, #11888, #11950, #11954, #11968, #12202, #12292, #12434, #12486.

Refs #12415.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.