Opened 16 years ago
Closed 11 years ago
#4078 closed defect (fixed)
Bring back the mincount functionality for the TagCloud macro
Reported by: | ogiesen | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | TagsPlugin |
Severity: | major | Keywords: | TagCloud argument missing |
Cc: | Trac Release: | 0.11 |
Description
I'm really missing this a lot. Without being able to eliminate one shot tags on demand, the cloud is mostly useless for me.
The version for trac 0.10 used to allow this.
I don't really care about the specific syntax or implementation. I can see how the new [[TagCloud(<expression>)]]
would no longer allow for using mincount=X
as an argument but there has to be some other way, or isn't there?
Attachments (0)
Change History (6)
comment:1 Changed 13 years ago by
Keywords: | TagCloud argument missing added |
---|---|
Type: | enhancement → defect |
comment:2 Changed 13 years ago by
Owner: | changed from Alec Thomas to Steffen Hoffmann |
---|---|
Status: | new → assigned |
The hardest part on this request is, to properly mark the last cloud item, when the last tag(s) is/are filtered out from the list due to not reaching mincount
count.
comment:3 Changed 13 years ago by
(In [10776]) TagsPlugin: Restore wiki macro argument mincount
for TagQuery
macro, refs #4078.
Sure, adding argument parsing for this macro as well has been a prerequisite.
Then, on re-designing the list builder algorithm, I introduced linebreaks for better readability of HTML source. While this removes the fix from [7380], linebreaks prevent IE from running tags together inside the cloud equally well.
As a tribute to #4503 the mincount check could yield a significant speedup for the list built by throwing (possibly many) tags with single occurrence away. Obsolete tag list length calulation saves a few more milliseconds here. No wait, just joking at the last one. New test in the loop eats up that gain, and more.
comment:4 Changed 13 years ago by
(In [10780]) TagsPlugin: Prepare mincount functionality for main tags page, refs #4078.
After re-enabling the TagCloud
macro let's prepare this for the main tag
cloud too.
This required some code relocating, and tests have been adapted as well.
comment:5 Changed 13 years ago by
(In [10781]) TagsPlugin: Add mincount functionality to main tags page, refs #4078 and #4503.
cloud_mincount
allows to cut default cloud size and reduce cluttering
and render time for the /tags
page a bit when tagging is in heavy use.
Calls of wiki macro TagCloud
are not affected by this configuration option.
If it has been there (did not check on my own), this is a regression, right?