Modify

Opened 9 years ago

Closed 4 years ago

#4078 closed defect (fixed)

Bring back the mincount functionality for the TagCloud macro

Reported by: ogiesen Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: major Keywords: TagCloud argument missing
Cc: Trac Release: 0.11

Description

I'm really missing this a lot. Without being able to eliminate one shot tags on demand, the cloud is mostly useless for me.

The version for trac 0.10 used to allow this.

I don't really care about the specific syntax or implementation. I can see how the new [[TagCloud(<expression>)]] would no longer allow for using mincount=X as an argument but there has to be some other way, or isn't there?

Attachments (0)

Change History (6)

comment:1 Changed 6 years ago by Steffen Hoffmann

Keywords: TagCloud argument missing added
Type: enhancementdefect

If it has been there (did not check on my own), this is a regression, right?

comment:2 Changed 6 years ago by Steffen Hoffmann

Owner: changed from Alec Thomas to Steffen Hoffmann
Status: newassigned

The hardest part on this request is, to properly mark the last cloud item, when the last tag(s) is/are filtered out from the list due to not reaching mincount count.

comment:3 Changed 6 years ago by Steffen Hoffmann

(In [10776]) TagsPlugin: Restore wiki macro argument mincount for TagQuery macro, refs #4078.

Sure, adding argument parsing for this macro as well has been a prerequisite.

Then, on re-designing the list builder algorithm, I introduced linebreaks for better readability of HTML source. While this removes the fix from [7380], linebreaks prevent IE from running tags together inside the cloud equally well.

As a tribute to #4503 the mincount check could yield a significant speedup for the list built by throwing (possibly many) tags with single occurrence away. Obsolete tag list length calulation saves a few more milliseconds here. No wait, just joking at the last one. New test in the loop eats up that gain, and more.

comment:4 Changed 6 years ago by Steffen Hoffmann

(In [10780]) TagsPlugin: Prepare mincount functionality for main tags page, refs #4078.

After re-enabling the TagCloud macro let's prepare this for the main tag cloud too. This required some code relocating, and tests have been adapted as well.

comment:5 Changed 6 years ago by Steffen Hoffmann

(In [10781]) TagsPlugin: Add mincount functionality to main tags page, refs #4078 and #4503.

cloud_mincount allows to cut default cloud size and reduce cluttering and render time for the /tags page a bit when tagging is in heavy use. Calls of wiki macro TagCloud are not affected by this configuration option.

comment:6 Changed 4 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

In 13815:

TagsPlugin: Completing preparation for v0.7 release.

Availability of that code as stable, tagged release
closes #2429, #3359, #3610, #3624, #3677, #3754, #3864, #3947, #3983, #4078, #4277, #4503, #4799, #5523, #7787, #7857, #8638, #9057, #9058, #9059, #9060, #9061, #9062, #9063, #9149, #9210, #9521, #9630, #9636, #10032, #10416, #10636, #11096, #11147, #11152, #11274, #11302, #11658 and #11659.

Additionally there are some issues and enhancement requests showing progress,
but known to require more work to resolve them satisfactorily, specifically
refs #2804, #4200, #8747 and #9064.

Thanks to all contributors and followers, that enabled and encouraged a good
portion of this development work.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.