Modify

Opened 11 years ago

Closed 7 years ago

#7857 closed defect (fixed)

[PATCH] Regression in Tag query functionality

Reported by: Steffen Hoffmann Owned by: Steffen Hoffmann
Priority: high Component: TagsPlugin
Severity: normal Keywords: regression
Cc: Ryan J Ollos, Itamar Ostricher Trac Release: 0.11

Description

Empty query as in

[[ListTagged()]]

raises NotImplementedError

This has been most relevant in some applications, that I upgraded today from v0.6 to recent trunk with devastating effect on the whole environments. In short, I had to temporarily disable KeywordSuggestPlugin installed there as well, and only later found a quick but ugly hack, to get it working again (see #7856).

It looks like KeywordSuggestPlugin has been built on a default query behavior to return all known tags, that got lost in later versions of TagsPlugin. So it should be fixed here, or I totally mistake the situation.

Attachments (3)

tagsplugin-7857-itamaro-v1.patch (538 bytes) - added by Itamar Ostricher 10 years ago.
patch against tagsplugin trunk
ListTaggedEmptyCall-r10708.png (7.0 KB) - added by Ryan J Ollos 10 years ago.
tagsplugin-7857-itamaro-v2.patch (1.7 KB) - added by Itamar Ostricher 10 years ago.
some more tweaks…

Download all attachments as: .zip

Change History (20)

comment:1 Changed 11 years ago by Chris Shenton

I was bitten by this as well, also using the KeywordSuggestPlugin with the autocomplete patch. I ended up backing out Tags to the 0.6 version.

I'm using Trac-0.12.

comment:2 in reply to:  1 Changed 11 years ago by Steffen Hoffmann

Owner: changed from Alec Thomas to Michael Renzmann

Replying to shentonfreude:

I was bitten by this as well, also using the KeywordSuggestPlugin with the autocomplete patch. ![...]

Thanks for the confirmation.

However, knowing the issue is there is just the first step. Did you investigate the offending change(s) in TagsPlugin by now? I'd love to help fix this, but have not enough time yet to research it on my own.

Don't hesitate to propose a patch against trunk. I'm well able to review and commit, if suitable.

Changed 10 years ago by Itamar Ostricher

patch against tagsplugin trunk

comment:3 Changed 10 years ago by Itamar Ostricher

Cc: Itamar Ostricher added
Summary: Regression in Tag query funcionality[PATCH] Regression in Tag query funcionality

I don't fully understand the underlying issue, but the attached patch fixed this for me.

Changed