Modify

Opened 6 years ago

Closed 4 years ago

#9063 closed enhancement (fixed)

Allow excluding realms from queries by default

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: normal Keywords: configuration query realms
Cc: Itamar Ostricher Trac Release: 0.11

Description

I would like to have a config-option that allows excluding, e.g., the ticket realm from tag-queries, such that only if I explicitly include it in the query it will be included.

The patch in #9059 implements this feature using a exclude_realms list-option.

Attachments (0)

Change History (5)

comment:1 Changed 6 years ago by Steffen Hoffmann

Cc: Itamar Ostricher added; anonymous removed
Keywords: configuration query realms added
Status: newassigned

Understand, but your proposed solution is flawed, because it does rely on argument counts, that some plugins are known to mess around with. I.e. my local FlexibleWikiPlugin install adds a 'node' argument everywhere, even outside the wiki domain/realm.

May it be, that this is a bug, but I'm reluctant to let it hit TagsPlugin for new stuff. I'm about to alter the implementation to be little more robust against this type of disturbance.

comment:2 Changed 6 years ago by Steffen Hoffmann

Ok, found another way, that doesn't depend on the number of arguments in the current request. :-)

comment:3 Changed 6 years ago by Steffen Hoffmann

(In [10661]) TagsPlugin: Provide configurable default list of realms to exclude from tags query, refs #9059 and #9063.

Administrators may configure tag realms to require explicite selection for every new tags query by adding them to a new ListOption 'exclude_realms' or 'listtagged_exclude_realms' for ListTagged macro calls respectively. The original suggestion has been contributed by Itamar Ostricher, thank you.

These changes include an additional workaround to get the expected result, even if you deselect all available realms. Otherwise this would have neutralized your setting for these options.

comment:4 Changed 5 years ago by Steffen Hoffmann

(In [12391]) TagsPlugin: Make realm configuration for ListTagged more effective, refs #7857 and #9063.

Settings for 'listtagged_exclude_realms' had no effect without a query. Itamar Ostricher discovered this issue in the initial implementation of the feature and suggested this change. Thanks for taking care.

Additionally the broken 'test_empty_content' test in tractags.tests.macros.ListTaggedMacroTestCase is fixed, and a regression test for the pending 'empty query' issue (#7857) has been introduced as well.

comment:5 Changed 4 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

In 13815:

TagsPlugin: Completing preparation for v0.7 release.

Availability of that code as stable, tagged release
closes #2429, #3359, #3610, #3624, #3677, #3754, #3864, #3947, #3983, #4078, #4277, #4503, #4799, #5523, #7787, #7857, #8638, #9057, #9058, #9059, #9060, #9061, #9062, #9063, #9149, #9210, #9521, #9630, #9636, #10032, #10416, #10636, #11096, #11147, #11152, #11274, #11302, #11658 and #11659.

Additionally there are some issues and enhancement requests showing progress,
but known to require more work to resolve them satisfactorily, specifically
refs #2804, #4200, #8747 and #9064.

Thanks to all contributors and followers, that enabled and encouraged a good
portion of this development work.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.