Opened 13 years ago
Closed 11 years ago
#9058 closed enhancement (fixed)
Let `TAGS_MODIFY` inherited `TAGS_VIEW` for more intuitive permissions
Reported by: | Steffen Hoffmann | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | low | Component: | TagsPlugin |
Severity: | normal | Keywords: | permission inheritance |
Cc: | Robert Corsaro, Mitar, Ryan J Ollos, Rob Guttman, Michael Renzmann | Trac Release: | 0.11 |
Description
Sure, Trac core, i.e. wiki permissions have no inheritance as well, and there are some good reasons for a high degree of privilege separation.
But it doesn't make any sense to give a modify permission without view, does it? In fact, you can hardly do one without the other, so there's no point to try, if not for diminishing the "joy" of hacking a ton of privileges per group/user for each Trac application you have to administrate.
So I speak up in favor of a sensible inheritance like so:
TAGS_VIEW remains just that: TAGS_VIEW TAGS_MODIFY gets extended to: TAGS_MODIFY + TAGS_VIEW
I'll happily provide the patch or the changeset to accomplish this, if it is acceptable and receives at least two more positive votes from fellow developers. Thanks for consideration.
Attachments (0)
Change History (8)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
+1
Same for all *_VIEW and *_MODIFY permissions. Good suggestion, Steffen.
comment:4 Changed 13 years ago by
This has confused me in the past as well. Happy to see you'll be fixing it! +1
comment:5 Changed 13 years ago by
(In [10627]) TagsPlugin: Improve permission definition for more intuitive permission settings, refs #9058 and #9059.
Add a third permission TAGS_ADMIN
for access to future 'tags' admin panel.
comment:6 Changed 13 years ago by
Status: | new → assigned |
---|
While I'll build upon this now I'm still open to corrective or encouraging feedback before the tags-0.7 release. Thanks for taking care.
comment:7 Changed 13 years ago by
(In [10639]) TagsPlugin: Add tag mass replacement functionality, refs #9058, #9059 and #9061.
This is a modified version of code originally contributed by Itamar Ostricher. I felt like improving usability by replacing the input field for old tag(s) with a select box containing all currently defined tags, where even multiple selection and tag mass deletion is possible now.
Thank you for your truely inspiring work, Itamar.
Bad formatting, sorry, have been too fast, so repeat just that once again: