Opened 6 years ago

Closed 3 years ago

#9058 closed enhancement (fixed)

Let `TAGS_MODIFY` inherited `TAGS_VIEW` for more intuitive permissions

Reported by: Steffen Hoffmann Owned by: Steffen Hoffmann
Priority: low Component: TagsPlugin
Severity: normal Keywords: permission inheritance
Cc: Robert Corsaro, Mitar, Ryan J Ollos, Rob Guttman, Michael Renzmann Trac Release: 0.11


Sure, Trac core, i.e. wiki permissions have no inheritance as well, and there are some good reasons for a high degree of privilege separation.

But it doesn't make any sense to give a modify permission without view, does it? In fact, you can hardly do one without the other, so there's no point to try, if not for diminishing the "joy" of hacking a ton of privileges per group/user for each Trac application you have to administrate.

So I speak up in favor of a sensible inheritance like so:

TAGS_VIEW remains just that: TAGS_VIEW TAGS_MODIFY gets extended to: TAGS_MODIFY + TAGS_VIEW

I'll happily provide the patch or the changeset to accomplish this, if it is acceptable and receives at least two more positive votes from fellow developers. Thanks for consideration.

Attachments (0)

Change History (8)

comment:1 Changed 6 years ago by Steffen Hoffmann

Bad formatting, sorry, have been too fast, so repeat just that once again:

TAGS_VIEW remains just that: TAGS_VIEW

comment:2 Changed 6 years ago by Rob Guttman


Same for all *_VIEW and *_MODIFY permissions. Good suggestion, Steffen.

comment:3 Changed 6 years ago by Mitar


comment:4 Changed 6 years ago by Ryan J Ollos

This has confused me in the past as well. Happy to see you'll be fixing it! +1

comment:5 Changed 6 years ago by Steffen Hoffmann

(In [10627]) TagsPlugin: Improve permission definition for more intuitive permission settings, refs #9058 and #9059.

Add a third permission TAGS_ADMIN for access to future 'tags' admin panel.

comment:6 Changed 6 years ago by Steffen Hoffmann

Status: newassigned

While I'll build upon this now I'm still open to corrective or encouraging feedback before the tags-0.7 release. Thanks for taking care.

comment:7 Changed 6 years ago by Steffen Hoffmann

(In [10639]) TagsPlugin: Add tag mass replacement functionality, refs #9058, #9059 and #9061.

This is a modified version of code originally contributed by Itamar Ostricher. I felt like improving usability by replacing the input field for old tag(s) with a select box containing all currently defined tags, where even multiple selection and tag mass deletion is possible now.

Thank you for your truely inspiring work, Itamar.

comment:8 Changed 3 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

In 13815:

TagsPlugin: Completing preparation for v0.7 release.

Availability of that code as stable, tagged release
closes #2429, #3359, #3610, #3624, #3677, #3754, #3864, #3947, #3983, #4078, #4277, #4503, #4799, #5523, #7787, #7857, #8638, #9057, #9058, #9059, #9060, #9061, #9062, #9063, #9149, #9210, #9521, #9630, #9636, #10032, #10416, #10636, #11096, #11147, #11152, #11274, #11302, #11658 and #11659.

Additionally there are some issues and enhancement requests showing progress,
but known to require more work to resolve them satisfactorily, specifically
refs #2804, #4200, #8747 and #9064.

Thanks to all contributors and followers, that enabled and encouraged a good
portion of this development work.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.