Modify

Opened 9 years ago

Closed 3 years ago

Last modified 3 years ago

#3624 closed defect (fixed)

invalid link when using more than one tag in tagged

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: normal Keywords: HTML links tag quote
Cc: Ryan J Ollos, Michael Renzmann, Jun Omae Trac Release: 0.11

Description

tagged:"tag1 tag2"

results to /tags?q=%27%22tag1+tag2%22%27, not to /tags?q=%27tag1+tag2%27 as expected

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by Steffen Hoffmann

Cc: Ryan J Ollos Michael Renzmann Jun Omae added; anonymous removed
Keywords: HTML links tag quote added
Owner: changed from Alec Thomas to Steffen Hoffmann
Status: newassigned

As hinted in my comment in #9057 this plugin's use of quotes for tags is wired.

This issue is the result of such insane incantations. As discussed before I think the best (only?) solution is to finally discontinue that quoting inside the '/tags' namespace.

comment:2 Changed 6 years ago by Steffen Hoffmann

(In [10785]) TagsPlugin: Correct tokenization for unary quotes, refs #3624 and #9057.

TagsQuery now has got a unit test in addition to the rather old doc tests. Thanks to Jun Omae for contributing most of the code to this changeset.

comment:3 Changed 5 years ago by Steffen Hoffmann

(In [11935]) TagsPlugin: Remove quotes from tag URLs, refs #3624.

comment:4 Changed 4 years ago by Steffen Hoffmann

(In [13129]) TagsPlugin: Add unit testing for the tag: TracWiki link resolver, refs #3624, #5523 and #9630.

Currently failing two of the tests due to known issues.

Ryan's proposed patch in #10612 has been helpful to get this done too.

comment:5 Changed 3 years ago by Steffen Hoffmann

In 13730:

TagsPlugin: Reworked wiki link resolver code, refs #3624, #5523 and #9630.

Newly added permission and resource existance awareness mimics wiki link
behavior for tickets and wiki pages.

Unit tests have been refactored too, partially with more reasonable test cases.

comment:6 Changed 3 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

In 13815:

TagsPlugin: Completing preparation for v0.7 release.

Availability of that code as stable, tagged release
closes #2429, #3359, #3610, #3624, #3677, #3754, #3864, #3947, #3983, #4078, #4277, #4503, #4799, #5523, #7787, #7857, #8638, #9057, #9058, #9059, #9060, #9061, #9062, #9063, #9149, #9210, #9521, #9630, #9636, #10032, #10416, #10636, #11096, #11147, #11152, #11274, #11302, #11658 and #11659.

Additionally there are some issues and enhancement requests showing progress,
but known to require more work to resolve them satisfactorily, specifically
refs #2804, #4200, #8747 and #9064.

Thanks to all contributors and followers, that enabled and encouraged a good
portion of this development work.

comment:7 Changed 3 years ago by Steffen Hoffmann

In 14158:

TagsPlugin: Test generator for emptyness instead of totally consuming it, refs #3624 and #11950.

Made it just as light as needed for something like a formatter method.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.